add advisory list to attestation report #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ego-docs canceled.
|
daniel-weisse
approved these changes
Sep 18, 2024
| } | ||
| } | ||
|
|
||
| if !hasAttributes { | ||
| return Report{}, errors.New("missing attributes in report claims") | ||
| } | ||
| report.TCBAdvisories, report.TCBAdvisoriesErr = getAdvisoriesFromTCBInfo(tcbInfo, tcbInfoIndex) |
There was a problem hiding this comment.
Will the tcbInfo and tcbIndex fields also be populated if attestation passes successfully?
I guess in that case one also just wouldn't need to check the advisories in the first cases, so should be fine either way
There was a problem hiding this comment.
Yes, they will, but advisoryIDs should be empty like in the first level of the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
TCBAdvisoriesto the attestation report so that a user can learn why the verified platform has a certainTCBStatus.Don't let attestation fail when an error occurs while getting the advisory array, but return it in
TCBAdvisoriesErr. Let the user decide how to handle the error.