Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow separate tabSize and indentSize #358

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

yshui
Copy link

@yshui yshui commented Dec 1, 2023

Please fill in this template.

  • Use a meaningful title for the pull request.
  • Use meaningful commit messages.
  • Run tsc w/o errors (same as npm run compile).
  • Run npm run lint w/o errors.

@yshui
Copy link
Author

yshui commented Dec 1, 2023

Fixes #346

@yshui
Copy link
Author

yshui commented Dec 1, 2023

this has weird interactions with vscode indentation detection, i need to look into this.

src/api.ts Outdated Show resolved Hide resolved
if indentSize is set to "tabSize" in config, and we try to set tabSize,
we will inadvertantly set indentSize as well. so decouple them in this
case.

and remove the hack that was here for this problem.
@huyz
Copy link

huyz commented Apr 4, 2024

What's the current status of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants