Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a demo #22

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add a demo #22

wants to merge 9 commits into from

Conversation

macro1
Copy link

@macro1 macro1 commented Oct 26, 2014

Porting @treyhunner's demo from https://github.com/treyhunner/editorconfig-slides to the editorconfig site.

  • give style love
  • cleanup selector logic

Adds gulp building (checking-in the compiled files, since publishing is currently through github's jekyll) and jQuery upgrade as well.

@macro1 macro1 changed the title Add a demo [WIP] Add a demo Oct 26, 2014
@treyhunner
Copy link
Member

I like this idea.

@macro1 macro1 changed the title [WIP] Add a demo Add a demo Oct 26, 2014
@macro1
Copy link
Author

macro1 commented Oct 26, 2014

It's functional now. I don't think I'll get to refactoring the selectors.

@macro1
Copy link
Author

macro1 commented Nov 13, 2014

I lied, it's cleaned up now... @treyhunner should be ready.

@treyhunner
Copy link
Member

It seems to be broken:

selection_237

It also seems to break other styling:

selection_236

@macro1
Copy link
Author

macro1 commented Nov 14, 2014

Ah. I missed that I had changed the feel of the code example above. The JS works fine for me though. Which browser? Are you testing using Jekyll?

@macro1
Copy link
Author

macro1 commented Nov 14, 2014

@treyhunner, I changed the script source link to a relative one, I'm pretty sure that's what was keeping it from working in whatever environment you were testing the changes in.

@jednano
Copy link
Member

jednano commented Aug 2, 2019

@macro1 are you still around? I realize this is 5 years old, but I'd like to take another look at it. Problem is, I can't clone your branch because GitHub says it's an unknown repo.

@macro1
Copy link
Author

macro1 commented Aug 3, 2019

@jedmao that is probably because I deleted my clone on Github at some point. You should be able to recover this branch from the 'pull' branches Github maintains with commands like this:

$ git fetch origin pull/22/head:demo
$ git checkout demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants