Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Symfony 7 #289

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Support for Symfony 7 #289

wants to merge 8 commits into from

Conversation

lruozzi9
Copy link

@lruozzi9 lruozzi9 commented Dec 5, 2023

No description provided.

@nikophil
Copy link

nikophil commented Jan 2, 2024

hello @lruozzi9

are you still willing to work on this PR? I think you can safely remove php 7.1 from the CI, since it is EOL since Decemer 2019
maybe even all php version until 8.0 included could be removed from the CI

any thoughts @jderusse ?

@CRC-Mismatch
Copy link

@nikophil the community (including myself) has been raising issues and sending PRs since over a year now about Symfony's newer versions incompatibilities, deprecations warnings and whatnot, but it seems that the maintainers have simply gone dark...

My company is currently using my fork (#281), and I noticed someone else also forked it but still didn't add anything new (chargePanelAndreas/EkinoNewRelicBundle); with that said, we'll possibly stop using NewRelic soon(ish ™️), so I won't be updating it any longer if/when that happens (and although I'd be more than happy to accept PRs to my own fork, someone else would have to send in one for Symfony 7 support, since we'll be staying in 6.4 at least until it receives only security updates).

Personally, if you don't have the availability to rework your projects to remove this bundle, I'd recommend trying to contribute with my fork (or picking any other fork, I've noticed there are some that just gave up on their PRs and have added Symfony 7 support directly to their main branches)

@lruozzi9 lruozzi9 force-pushed the patch-1 branch 3 times, most recently from b45c1ba to fee08bc Compare April 29, 2024 10:40
@lruozzi9
Copy link
Author

lruozzi9 commented May 6, 2024

Hello @nikophil. Sorry for the delay. Now the CI is green except for the dev branch (Symfony 7.1 and PHP 8.3). But I will not currently spend too much time on that as it is not necessary.
If you could have a look at it good, otherwise we should fork the repo or use an already existing as stated by @CRC-Mismatch.

@nikophil
Copy link

nikophil commented May 7, 2024

hi @lruozzi9

face of the lack of maintenance of this bundle, and the absence of response on trivial but yet important subjects like this, we've decided to internalize how we interact with NewRelic

that being said, I've looked at the code of the PR and seems good 👍

@janvernieuwe
Copy link

Any chance of getting this merged and tagged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants