Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docker file #263

Closed
wants to merge 1 commit into from
Closed

Conversation

jackshirazi
Copy link
Contributor

Note

  • We're only doing the wolfi dockerfile (the image needs cp for the otel k8s operator, so we can't start from scratch)
  • The /javaagent.jar path is the path the otel k8s operator needs so that the image can be used for auto-instrumentation
  • Including the extension jar means the docker image can alternatively be used by the otel k8s operator as an extension for the vanilla otel agent. This can be any path, using an extensions dir seems like a reasonable choice

@jackshirazi jackshirazi requested review from a team May 23, 2024 12:41
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we can move away from the shell scripts and use the GitHub actions native support?

We did that for some other APM Agents, and it helped us to use the provenance/attes with GitHub actions.

https://github.com/elastic/apm-agent-nodejs/blob/1241a5845a5e4727ee5a833555dafe7e5d2d3034/.github/workflows/release.yml#L47-L77 is how we use it if it helps

In fact, I did some thing for the apm-agent-java but didn't transition to ready:

Maybe we can apply that new mechanism to this project, what do you think? I'm happy to collaborate on this PR and make that happen if it helps

@jackshirazi
Copy link
Contributor Author

Do you think we can move away from the shell scripts and use the GitHub actions native support?

Happy to do that, I just took the existing scripts from apm-agent-java here, but no problem switching before committing

@jackshirazi
Copy link
Contributor Author

Leaving this unclosed for now, but #268 is the action based implementation

@jackshirazi
Copy link
Contributor Author

Won't use this, we'll use the github actions version instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants