Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device dehydration v2 #7630

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Device dehydration v2 #7630

merged 1 commit into from
Aug 12, 2023

Conversation

stefanceriu
Copy link
Member

  • add support for device dehydration v2 i.e. org.matrix.msc3814
  • run dehydration flows after successfully recovering or creating secrets
  • enable said flows based on .well-known org.matrix.msc3814 config key
  • delete previous implementation and helper methods

Based on matrix-org/matrix-ios-sdk#1807

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage: 9.67% and no project coverage change.

Comparison is base (04c7a02) 12.21% compared to head (9b59428) 12.22%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7630   +/-   ##
========================================
  Coverage    12.21%   12.22%           
========================================
  Files         1648     1648           
  Lines       163667   163614   -53     
  Branches     67195    67154   -41     
========================================
+ Hits         19996    19999    +3     
+ Misses      143026   142970   -56     
  Partials       645      645           
Flag Coverage Δ
uitests 55.05% <ø> (ø)
unittests 6.07% <9.67%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...xKit/Controllers/MXKAuthenticationViewController.m 19.87% <ø> (+0.63%) ⬆️
Riot/Modules/MatrixKit/Models/Account/MXKAccount.m 7.53% <ø> (+0.23%) ⬆️
...dules/MatrixKit/Models/Account/MXKAccountManager.m 17.03% <ø> (-0.16%) ⬇️
...verWithKey/SecretsRecoveryWithKeyCoordinator.swift 0.00% <0.00%> (ø)
...coverWithKey/SecretsRecoveryWithKeyViewModel.swift 0.00% <0.00%> (ø)
...ase/SecretsRecoveryWithPassphraseCoordinator.swift 0.00% <0.00%> (ø)
...hrase/SecretsRecoveryWithPassphraseViewModel.swift 0.00% <0.00%> (ø)
...s/Secrets/Recover/SecretsRecoveryCoordinator.swift 0.00% <0.00%> (ø)
...coveryKey/SecretsSetupRecoveryKeyCoordinator.swift 0.00% <0.00%> (ø)
...RecoveryKey/SecretsSetupRecoveryKeyViewModel.swift 0.00% <0.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although missing a changelog.

Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it only working if you verify with 4S?

@BillCarsonFr
Copy link
Member

Fixes #6366

- add support for device dehydration v2 i.e. `org.matrix.msc3814`
- run dehydration flows after successfully recovering or creating secrets
- enable said flows based on .well-known `org.matrix.msc3814` config key
- delete previous implementation and helper methods
@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@stefanceriu stefanceriu merged commit 9ba1d7e into develop Aug 12, 2023
9 checks passed
@stefanceriu stefanceriu deleted the stefan/deviceDehydration branch August 12, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants