Update matrix-sdk-crypto-nodejs to 0.2.0-beta.1 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewFerr
reviewed
Jun 11, 2024
package.json
Outdated
| @@ -110,5 +110,6 @@ | |||
| "testMatch": [ | |||
| "<rootDir>/test/**/*Test.ts" | |||
| ] | |||
| } | |||
| }, | |||
| "packageManager": "[email protected]+sha512.ff4579ab459bb25aa7c0ff75b62acebe576f6084b36aa842971cf250a5d8c6cd3bc9420b22ce63c7f93a0857bc6ef29291db39c3e7a23aab5adfd5a4dd6c5d71" | |||
There was a problem hiding this comment.
Is this strictly necessary? IMO it's better to be in its own release/PR, and should update to yarn >=2 anyhow (or at least the latest 1.22.x).
There was a problem hiding this comment.
This is my package manage being a berk, it seems insistent on setting this everywhere. I need to go and disable it for now, because I think this needs an explicit PR.
AndrewFerr
reviewed
Jun 11, 2024
|
Probably this branch should land in upstream, but that's a bigger chunk of work as we're quite diverged. |
AndrewFerr
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist