-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental SSS #36
Draft
dbkr
wants to merge
12
commits into
develop
Choose a base branch
from
dbkr/sss
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Experimental SSS #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working branch to get SSS functional on element-web. Requires matrix-org/matrix-js-sdk#4400
kegsay
added
the
T-Enhancement
New features, changes in functionality, performance boosts, user-facing improvements
label
Sep 13, 2024
This is actually required for SSS because otherwise it would use the proxy over native support.
- Update the spidering code to spider all the relevant lists. - Add canonical alias to the required_state to allow room name calcs to work. Room sort order is busted because we don't yet look at `bump_stamp`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
T-Enhancement
New features, changes in functionality, performance boosts, user-facing improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working branch to get SSS functional on element-web.
Requires matrix-org/matrix-js-sdk#4400
Current status is that it syncs, but the room lists don't load until the next sync request, so take 30s to appear. This is because element web doesn't add the requests for the lists until after sliding sync has started, and SSS doesn't support txn_id which the SS impl uses to track requests for cancellation (it looks like previously it would have started the second request and the shortly after, canceled it and made a new one with the room lists).
Checklist
public
/exported
symbols have accurate TSDoc documentation.