-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove images from message notification e-mails. #17598
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Olivier 'reivilibre <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a before/after image of what this change looks like?
@@ -1,19 +1,6 @@ | |||
{%- for message in notif.messages %} | |||
<tr class="{{ "historical_message" if message.is_historical else "message" }}"> | |||
<td class="sender_avatar"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove this column entirely?
@@ -1,17 +1,6 @@ | |||
<table class="room"> | |||
<tr class="room_header"> | |||
<td class="room_avatar"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise here.
Having these images here has been a liability because it gives cause for complaints about the e-mails,
which then affects our sender reputation.
These images will also be broken by the upcoming media authentication changes, so there's little point in keeping them around either.
Base:
develop
Original commit schedule, with full messages:
Remove images from message notification e-mails
Remove room avatars from message notification e-mails