Fix typo in test name #36196
Open
Fix typo in test name #36196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Greg Greenway <[email protected]>
zuercher
reviewed
Sep 18, 2024
| @@ -496,7 +496,7 @@ TEST_P(HttpHealthCheckIntegrationTest, SingleEndpointGoAway) { | |||
| // followup health check would happen. Using real time solves this because then | |||
| // the ordering of advancing the time system and enabling the health check timer | |||
| // is inconsequential. | |||
| TEST_P(RealTimeHttpHealthCheckIntegrationTest, SingleEndpointGoAwayErroSingleEndpointGoAwayErrorr) { | |||
| TEST_P(RealTimeHttpHealthCheckIntegrationTest, SingleEndpointGoAwayErroSingleEndpointGoAwayError) { | |||
There was a problem hiding this comment.
Haha. I noticed one typo on the line but not the other. Yes, I'll fix that too.
/wait
There was a problem hiding this comment.
Kinda makes me wonder if this was just supposed to be SingleEndpointGoAwayError and it got pasted in twice with a cursor move in between.
Signed-off-by: Greg Greenway <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]