Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Split logic of SnakeModePolymerBondRenderer by several classes #5497

Open
DmitriiP-EPAM opened this issue Sep 11, 2024 · 0 comments · May be fixed by #5498
Open

Refactor: Split logic of SnakeModePolymerBondRenderer by several classes #5497

DmitriiP-EPAM opened this issue Sep 11, 2024 · 0 comments · May be fixed by #5498
Assignees
@DmitriiP-EPAM
Labels
feature request
Milestone
Ketcher 2.26.0-rc...

Comments

@DmitriiP-EPAM
Copy link
Collaborator

DmitriiP-EPAM commented Sep 11, 2024 •
edited
Loading

Create:

  • SnakeModeBackboneBondRenderer (black “snake” line)
  • SnakeModeSideChainBondRenderer (blue “snake” line)
  • SnakeModeRNABaseAndSugarBondRenderer (black straight line)

Next step after #5128
@DmitriiP-EPAM DmitriiP-EPAM self-assigned this Sep 11, 2024
DmitriiP-EPAM added a commit that referenced this issue Sep 11, 2024
@DmitriiP-EPAM
#5497 – Refactor (Connection.ts): Specify the types
dfdea0a
DmitriiP-EPAM added a commit that referenced this issue Sep 11, 2024
@DmitriiP-EPAM
#5497 – Refactor (Connection.ts): Rename xOffset
33540e3
@DmitriiP-EPAM DmitriiP-EPAM linked a pull request Sep 11, 2024 that will close this issue
#5497 – Refactor: Specify the types of classes for SnakeModePolymerBondRenderer #5498
Open
13 tasks
DmitriiP-EPAM added a commit that referenced this issue Sep 12, 2024
@DmitriiP-EPAM
#5497 – Refactor (SnakeModePolymerBondRenderer.ts): Specify the types
b7a4ae8
DmitriiP-EPAM added a commit that referenced this issue Sep 12, 2024
@DmitriiP-EPAM
#5497 – Refactor (Connection.ts): Specify the types (amend)
f7ee479
DmitriiP-EPAM added a commit that referenced this issue Sep 12, 2024
@DmitriiP-EPAM
Revert "#5497 – Refactor (Connection.ts): Rename xOffset"
aaf6402 
This reverts commit 33540e3.
DmitriiP-EPAM added a commit that referenced this issue Sep 12, 2024
@DmitriiP-EPAM
#5497 – Refactor (SnakeModePolymerBondRenderer.ts): Specify the types…
c3d208e 
…, refactor the calculation of `endOfPathPart`
DmitriiP-EPAM added a commit that referenced this issue Sep 12, 2024
@DmitriiP-EPAM
#5497 – Refactor (CanvasMatrix.ts): Specify the types
4f9eeb8
DmitriiP-EPAM added a commit that referenced this issue Sep 12, 2024
@DmitriiP-EPAM
#5497 – Refactor (CanvasMatrix.ts): Use new Connection(6)
ca58260
DmitriiP-EPAM added a commit that referenced this issue Sep 13, 2024
@DmitriiP-EPAM
#5497 – Refactor (Connection.ts): Rename xOffset
49fb5f1
DmitriiP-EPAM added a commit that referenced this issue Sep 13, 2024
@DmitriiP-EPAM
#5497 – Refactor (SnakeModePolymerBondRenderer.ts): Change FIXME text
bfec6da
DmitriiP-EPAM added a commit that referenced this issue Sep 13, 2024
@DmitriiP-EPAM
#5497 – Refactor (Connection.ts): Rename `ConnectionDirectionInDegree…
fb6b2eb 
…s`, `ConnectionDirectionOfLastCell`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmitriiP-EPAM DmitriiP-EPAM

Labels
feature request
Projects
Technical Debt
Status: In review
Milestone
Ketcher 2.26.0-rc.1 (Current)
1 participant
@DmitriiP-EPAM