Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5497 – Refactor: Specify the types of classes for SnakeModePolymerBondRenderer #5498

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

#5497 – Refactor: Specify the types of classes for SnakeModePolymerBondRenderer #5498

wants to merge 11 commits into from

Conversation

DmitriiP-EPAM
Copy link
Collaborator

@DmitriiP-EPAM DmitriiP-EPAM commented Sep 11, 2024 •
edited
Loading

How the feature works? / How did you fix the issue?

  • Specify the type of Connection.direction.
  • Rename Connection.xOffset.
  • Mark a part of the Connection's as readonly.
  • Create Connection objects via new.

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@DmitriiP-EPAM DmitriiP-EPAM self-assigned this Sep 11, 2024
@DmitriiP-EPAM DmitriiP-EPAM linked an issue Sep 11, 2024 that may be closed by this pull request
Refactor: Split logic of SnakeModePolymerBondRenderer by several classes #5497
Open
@DmitriiP-EPAM DmitriiP-EPAM added technical debt refactor Code refactoring, without changing the functionality labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeyGirin AlexeyGirin Awaiting requested review from AlexeyGirin

@NataliaLoginova NataliaLoginova Awaiting requested review from NataliaLoginova

@svvald svvald Awaiting requested review from svvald

@rrodionov91 rrodionov91 Awaiting requested review from rrodionov91

@KristinaKasyanovskaya KristinaKasyanovskaya Awaiting requested review from KristinaKasyanovskaya

At least 1 approving review is required to merge this pull request.

Assignees

@DmitriiP-EPAM DmitriiP-EPAM

Labels
refactor Code refactoring, without changing the functionality technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: Split logic of SnakeModePolymerBondRenderer by several classes
1 participant
@DmitriiP-EPAM