Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EndPlot() not deducing auto color for ImPlotCol_PlotBorder #517

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

elvissteinjr
Copy link
Contributor

EndPlot() currently accesses the style color field directly when deciding whether to render the border and behaves wrongly if ImPlotCol_PlotBorder is set to IMPLOT_AUTO_COL, never rendering it. Despite being documented to defaulting to ImGuiCol_Border's value.

Of course the easy fix on the application end is to set ImPlotCol_PlotBorder explicitly. This change may also be considered as a breaking change as it will start adding borders to plots that previously had none with default styling.
Changing the documentation to reflect the current behavior could be an alternative if preferred.

@epezent epezent merged commit 065acc3 into epezent:master Sep 26, 2023
18 checks passed
@epezent
Copy link
Owner

epezent commented Sep 26, 2023

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants