Fix EndPlot() not deducing auto color for ImPlotCol_PlotBorder #517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EndPlot() currently accesses the style color field directly when deciding whether to render the border and behaves wrongly if ImPlotCol_PlotBorder is set to IMPLOT_AUTO_COL, never rendering it. Despite being documented to defaulting to ImGuiCol_Border's value.
Of course the easy fix on the application end is to set ImPlotCol_PlotBorder explicitly. This change may also be considered as a breaking change as it will start adding borders to plots that previously had none with default styling.
Changing the documentation to reflect the current behavior could be an alternative if preferred.