ci: refactor and improve times #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upgrade removes curl from the dependency tree, which is quite a heavy dep as it includes building curl from source.
kkovaacs
reviewed
Nov 7, 2023
There was a problem hiding this comment.
LGTM, except the Docker build.
I think we'll have to add libzstd-dev to the list of packages we install in prepare.sh.
kkovaacs
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (hopefully) improves the current CI situation by reducing the time tests take to build.
Highlights:
moldlinker (somehow this got removed for tests - probably my fault).-syscrates are no longer bundled but rather use the vendored crates.This might cause an issue with docker?It does cause docker changes but those have been applied.