feat: download and store block commitment signatures #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a temporary measure for helping the P2P effort until proper consensus is deployed on the network Starknet has added the concept of block commitment signatures provided by the gateway. The idea is that those signatures are propagated along with block and state update data over P2P and thus nodes receiving that data can verify that the data they've received matches the data produced by the sequencer. For more details please check the community forum post.
This PR is the first step towards that direction: it implements downloading and storing the signatures in our database but does not add it to the P2P implementation yet (nor does it implement the actual verification).