feat(rpc): add standardize RPC endpoints #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vX_Y instead of vX.Y although the current version is still supported.
Mirko-von-Leipzig
force-pushed
the
mirko/standardize_rpc_url
branch
from
15e5755
to
81a32b8
Compare
sergey-melnychuk
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RPC endpoints using
/rpc/vX_Yin addition to/rpc/vX.Y.This is part of an effort to standardize these endpoints across all nodes. In time we will deprecate and remove
/rpc/vX.Y.An open question is: should we instead move to hosting them on root instead of in
/rpc. i.e./vX_Ywhich is more inline with other nodes. We originally chose a more directory like structure, in case we ever wanted to host more (non-json-rpc) things on the same port. This still makes sense to me, but we also have nothing else hosted here..Update: waiting on starkware feedback regarding
/rpc/xxxor/xxx.