fix(executor): map VM errors to custom errors #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirko-von-Leipzig
approved these changes
Nov 15, 2023
pierre-l
approved these changes
Nov 15, 2023
|
Could you create a bug issue for this to close? |
Mirko-von-Leipzig
approved these changes
Nov 15, 2023
Otherwise we don't properly return those to the JSON-RPC client and log them on WARN log level instead. None of these errors (apart from the anyhow::Error mapping) are internal issues but instead errors that were encountered during contract execution.
So that we don't litter logs with these errors.
kkovaacs
force-pushed
the
krisztian/exeuction-errors-should-be-custom
branch
from
62dfeb4
to
1016e34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we don't properly return those to the JSON-RPC client and log them on WARN log level instead.
None of these errors (apart from the anyhow::Error mapping) are internal issues but instead errors that were encountered during contract execution.
Closes #1530