Add support for request/stream-of-responses in p2p #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHr15F0x
force-pushed
the
chris/rrs
branch
12 times, most recently
from
0a28bb5
to
0695796
Compare
CHr15F0x
force-pushed
the
chris/rrs
branch
2 times, most recently
from
ac3d4cb
to
627c7a9
Compare
CHr15F0x
changed the title
sergey-melnychuk
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
I don't think thorough reviews of such huge changes are necessary (or make much sense, to be completely honest), while the branch gets stale real quick.
If the functional tests are present (and do pass :)), I think the PR is good to go. Any issues are then simply addressed in follow up pull requests, not necessary by the author of the original PR.
Sounds contraversive, I know, so it is up for a discussion of course.
…ndRequestAcceptedAwaitingResponses in Handler::poll
…ponseStreamClosed
…est and vice versa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1328
p2p_streamis a fork oflibp2p-request-responsewhich allows for a stream of responses instead of a single message.