Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: harden docker workflow #1546

Merged
merged 1 commit into from
Nov 21, 2023
Merged

ci: harden docker workflow #1546

merged 1 commit into from
Nov 21, 2023

Conversation

Mirko-von-Leipzig
Copy link
Contributor

@Mirko-von-Leipzig Mirko-von-Leipzig commented Nov 20, 2023

This PR couples the docker image tagging to run after a github release, instead of on a tag being pushed.

Our current release workflow is:

  1. Push version tag
  2. Docker workflow runs and uploads an image. This includes tagging the image with the version and latest
  3. Formally release on github

External parties moniter our docker images for new releases, instead of our github releases. So what occasionally occurs is that we find a bug between steps (2) and (3) but since some users already have the "release" via dockerhub we cannot properly abort the faulty release.

What this PR does is change the workflow to:

  1. Push version tag
  2. Docker workflow runs and uploads an image without tagging it
  3. Formally release on github
  4. This triggers another workflow which will tag the image from (2)

@Mirko-von-Leipzig Mirko-von-Leipzig changed the title Release ci: harden docker workflow Nov 21, 2023
@Mirko-von-Leipzig Mirko-von-Leipzig marked this pull request as ready for review November 21, 2023 09:28
@Mirko-von-Leipzig Mirko-von-Leipzig merged commit 4de98c2 into main Nov 21, 2023
7 checks passed
@Mirko-von-Leipzig Mirko-von-Leipzig deleted the release branch November 21, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants