Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ff-asm and inlining #1601

Merged
merged 1 commit into from
Nov 30, 2023
Merged

feat: ff-asm and inlining #1601

merged 1 commit into from
Nov 30, 2023

Conversation

mikdk
Copy link
Collaborator

@mikdk mikdk commented Nov 29, 2023

Adds x86-asm for the field via ark-ff-asm. Also inlines field operations, and properly use rand instead of rand_core.

This speed up some crypto operations with 10-30% when compiled with:

RUSTFLAGS="-C target-feature=+bmi2,+adx"

@mikdk mikdk requested review from pierre-l and a team as code owners November 29, 2023 21:56
kkovaacs
kkovaacs approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@kkovaacs kkovaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I assume we'd actually need to update our Docker build so that it uses these additional compiler flags to take full advantage of this optimization.

@kkovaacs kkovaacs merged commit a08043e into main Nov 30, 2023
7 checks passed
@kkovaacs kkovaacs deleted the crypto_asm_inline branch November 30, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkovaacs kkovaacs kkovaacs approved these changes

@sergey-melnychuk sergey-melnychuk sergey-melnychuk approved these changes

@pierre-l pierre-l Awaiting requested review from pierre-l

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikdk @kkovaacs @sergey-melnychuk