feat(proof): pathfinder_getClassProof endpoint #2179
+141
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sistemd
reviewed
Aug 22, 2024
There was a problem hiding this comment.
I see nothing objectionable, but @kkovaacs is our trie expert.
Also not sure if something like this will be in the v0.8 spec maybe, so this endpoint won't be necessary anymore. There's a PR open for this in the specs repo. (I understand you may already be aware of this.)
kkovaacs
reviewed
Aug 23, 2024
Comment on lines
+115
to
+136
| fn leaf(&self, path: &BitSlice<u8, Msb0>) -> anyhow::Result<Option<Felt>> { | ||
| assert!(path.len() == 251); | ||
|
|
||
| let Some(block) = self.block else { | ||
| return Ok(None); | ||
| }; | ||
|
|
||
| let sierra = | ||
| ClassHash(Felt::from_bits(path).context("Mapping leaf path to contract address")?); | ||
|
|
||
| let casm = self | ||
| .tx | ||
| .casm_hash_at(block.into(), sierra) | ||
| .context("Querying CASM hash")?; | ||
| let Some(casm) = casm else { | ||
| return Ok(None); | ||
| }; | ||
|
|
||
| let value = self.tx.class_commitment_leaf(block, &casm)?.map(|x| x.0); | ||
|
|
||
| Ok(value) | ||
| } |
There was a problem hiding this comment.
Hmm, this seems a bit strange. How is this actually different from ClassStorage::leaf()?
There was a problem hiding this comment.
It's not, it's an artifact from earlier attempts. Will remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new endpoint
pathfinder/v0.1/pathfinder_getClassProofthat returns the Merkle proof of any class hash in the class trie.This new endpoint is necessary to run the Starknet OS to completion as we need the full class commitment as input of the OS.