fix(p2p/client/peer_agnostic): limit sync request block ranges #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkovaacs
force-pushed
the
krisztian/limit-p2p-sync-query-block-ranges
branch
from
0b116e6
to
148c8cf
Compare
kkovaacs
force-pushed
the
krisztian/limit-p2p-sync-query-block-ranges
branch
4 times, most recently
from
b9c0527
to
60aecf2
Compare
sistemd
approved these changes
Sep 12, 2024
CHr15F0x
reviewed
Sep 13, 2024
Some nodes (like Juno) do not limit how many responses they return for a sync query. Since Pathfinder requests the whole gap (possibly hundreds of thousands of blocks) by default this leads to a sync request that then times out (because we currently have a "global" timeout on the sync protocol streams). This change makes sure that we never request more than 500 blocks worth of data at once. Closes #2121
kkovaacs
force-pushed
the
krisztian/limit-p2p-sync-query-block-ranges
branch
from
60aecf2
to
cfb0a7c
Compare
CHr15F0x
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some nodes (like Juno) do not limit how many responses they return for a sync query. Since Pathfinder requests the whole gap (possibly hundreds of thousands of blocks) by default this leads to a sync request that then times out (because we currently have a "global" timeout on the sync protocol streams).
This change makes sure that we never request more than 500 blocks worth of data at once.
Closes #2121