fix(pathfinder/state/sync): bulk sync should exit right after first error #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHr15F0x
approved these changes
Sep 23, 2024
t00ts
approved these changes
Sep 24, 2024
kkovaacs
force-pushed
the
krisztian/bulk-sync-should-exit-on-error
branch
from
50efa95
to
82969f4
Compare
CHr15F0x
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise there's an edge case where we're getting into a loop of continuing to try and fetch blocks even though we're getting "block not found" errors from the feeder gateway.
We might just lose some data we've fetched and verified but overall not having this optimization feels safer.