Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use libp2p::kad internal bootstrap trigger #2261

Merged
merged 3 commits into from
Sep 24, 2024
Merged

feat: use libp2p::kad internal bootstrap trigger #2261

merged 3 commits into from
Sep 24, 2024
+68 −321

Conversation

CHr15F0x
Copy link
Member

@CHr15F0x CHr15F0x commented Sep 23, 2024 •
edited
Loading

Fixes: #2189

@CHr15F0x CHr15F0x force-pushed the chris/bootstrap branch 3 times, most recently from 0e26751 to 2e667b3 Compare September 23, 2024 21:42
@CHr15F0x CHr15F0x marked this pull request as ready for review September 23, 2024 21:47
@CHr15F0x CHr15F0x requested a review from a team as a code owner September 23, 2024 21:47
kkovaacs
kkovaacs approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@kkovaacs kkovaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CHr15F0x CHr15F0x marked this pull request as draft September 24, 2024 06:56
@CHr15F0x CHr15F0x marked this pull request as ready for review September 24, 2024 10:15
@CHr15F0x
Copy link
Member Author

I removed the low_watermark as per offline discussion, in favor of the new automatic bootstrap with a fixed watermark of 20.

@CHr15F0x CHr15F0x merged commit b5400d3 into main Sep 24, 2024
7 checks passed
@CHr15F0x CHr15F0x deleted the chris/bootstrap branch September 24, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkovaacs kkovaacs kkovaacs approved these changes

@t00ts t00ts t00ts approved these changes

@sistemd sistemd sistemd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

P2P: update bootstrap logic, remove explicit triggering
4 participants
@CHr15F0x @kkovaacs @t00ts @sistemd