Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

ci: run tests in Node.js 22 #67

Merged
merged 2 commits into from
Apr 25, 2024
Merged

ci: run tests in Node.js 22 #67

merged 2 commits into from
Apr 25, 2024

Conversation

fasttime
Copy link
Member

Node.js 22 has been released. This PR updates the GitHub Actions CI workflow to run tests also in Node.js 22.

It also bumps actions/checkout and actions/setup-node used in the workflow to the latest versions. This aligns it with other workflows in the eslint organization and ensures that the actions will be updated to work with upcoming version of Node.js.

@fasttime fasttime marked this pull request as ready for review April 25, 2024 05:51
@aladdin-add
Copy link
Member

also update the release-please:

- uses: actions/checkout@v3
if: ${{ steps.release.outputs.release_created }}
- uses: actions/setup-node@v3
with:
node-version: lts/*
?

@fasttime
Copy link
Member Author

also update the release-please:

- uses: actions/checkout@v3
if: ${{ steps.release.outputs.release_created }}
- uses: actions/setup-node@v3
with:
node-version: lts/*

?

Done in 7a39126.

Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit f986fec into main Apr 25, 2024
9 checks passed
@aladdin-add aladdin-add deleted the ci-node22 branch April 25, 2024 06:06
@github-actions github-actions bot mentioned this pull request Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants