Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

ci: reduce list of releasable tags to feat, fix and perf #68

Merged
merged 2 commits into from
May 17, 2024

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented May 17, 2024

Per eslint/eslint#18455, only commits tagged as feat, fix, or perf should trigger a release.

This PR removes all other tags from changelog-types in the release-please configuration.

This means that release-please will no longer consider commits tagged as docs, build, chore, ci, refactor, or test as "releasable units" and will thus no longer create a release PR for those commits. Note that this also means that those commits won't be included in the changelog.

I'm not sure what will release-please do with #65 after we merge this. Since there are no "releasable units" committed at the moment, perhaps it will close the PR?

{ "type": "ci", "section": "Chores", "hidden": false },
{ "type": "refactor", "section": "Chores", "hidden": false },
{ "type": "test", "section": "Chores", "hidden": false }
{ "type": "perf", "section": "Chores", "hidden": false }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe rename this section to "Performance Improvements"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed in a1722cf

@mdjermanovic
Copy link
Member Author

I'm not sure what will release-please do with #65 after we merge this. Since there are no "releasable units" committed at the moment, perhaps it will close the PR?

By testing in a test repo, it seems that it won't close the existing release PR. But we could close it manually & remove the label & delete the branch, and next time we commit a feat, fix, or perf, it will create a new release PR.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Yes, I think it will probably close the PR as it does seem to update with every commit. Interested to see...

@nzakas nzakas merged commit 787f72a into main May 17, 2024
9 checks passed
@nzakas nzakas deleted the release-please-tags branch May 17, 2024 14:15
@mdjermanovic
Copy link
Member Author

It didn't close the PR. Looks like it found there are no releasable commits and decided that there's no further action needed :)

✔ No user facing commits found since b75dc7d1d827bd82d55379644005f17a1db9c749 - skipping

I'll remove the label, close the PR, and delete the branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants