Add chip-specific features for tests/examples #2175
+57
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
x
branch
6 times, most recently
from
564c0b2
to
d9d7b6b
Compare
bjoernQ
reviewed
Sep 19, 2024
|
|
||
| // The trailing ':' on metadata keys is optional :) |
There was a problem hiding this comment.
technically a change but given I didn't even know this I guess that is totally fine
bjoernQ
reviewed
Sep 19, 2024
|
|
||
| for chip in chips { | ||
| chip_features.insert(chip, values.clone()); | ||
| } | ||
| } else { | ||
| log::warn!("Unrecognized metadata key '{key}', ignoring"); |
There was a problem hiding this comment.
unrelated but we might consider to make this an hard error and panic - took we a while to recognize I was testing with CHIP_FEATURE(esp32s3) 😄
bjoernQ
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivator