Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate output; Add notification for success #1290

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix duplicate output; Add notification for success #1290

wants to merge 4 commits into from

Conversation

radurentea
Copy link
Collaborator

Description

Removed duplicated output to ESP-IDF channel, when user sets device target (ex: esp32, esp32s2 etc)
Added notification for successfully setting the target
Improved error message

JIRA: https://jira.espressif.com:8443/browse/VSC-1430

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

  1. Open a project
  2. Set any device target
  3. Check "ESP-IDF" Output channel. There should be no duplicates of Executing "cmake
  4. When setting the device is finished, you should get a notification no matter if it's successful or not.

How has this been tested?

As described above

Test Configuration:

  • ESP-IDF Version: 5.2.2
  • OS (Windows,Linux and macOS): Windows 11

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@radurentea radurentea added the needs translation:CN Chinese translation is required label Aug 26, 2024
@radurentea radurentea self-assigned this Aug 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

Download the artifacts for this pull request:

@radurentea
Copy link
Collaborator Author

Hi @brianignacio5, PTAL

brianignacio5
brianignacio5 requested changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can still see the same message being output in 2 places.

Suggest further reduce code duplication here.

src/espIdf/setTarget/index.ts Outdated Show resolved Hide resolved
brianignacio5
brianignacio5 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radurentea
Copy link
Collaborator Author

Hi @Fabricio-ESP , PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianignacio5 brianignacio5 brianignacio5 approved these changes

Assignees

@radurentea radurentea

Labels
needs translation:CN Chinese translation is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radurentea @brianignacio5