Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onEnd handler into traverse. Closes #73 #74

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

a-x-
Copy link

@a-x- a-x- commented Jul 4, 2016

see explanation is issue #73

estraverse.js Outdated
@@ -551,6 +554,10 @@
}
}
}

if (onEnd) {
onEnd();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably use setTimeout here to avoid blocking.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, one moment

@a-x-
Copy link
Author

a-x- commented Jul 10, 2017

done

Can you merge or ask the maintainer to merge this?

(you can use merge-squash gh-button also)

@michaelficarra
Copy link
Member

I like the idea. I don't think I like the name. We have enter and leave, so maybe finish or done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants