Update go to 1.21.5 #115
Merged
Update go to 1.21.5 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Valdes <[email protected]>
|
I have a failure with the static analysis. I'm reviewing to see what's the issue. |
|
@jmhbnz, can you approve this draft PR so it can run the analysis check? I drafted it, as the result from the analysis is not very clear on what's wrong. I fixed one of the issues, but I still have another failure and want to wait to have the PR marked as ready, as it still needs work. |
Set the same version that the etcd-io/etcd repository uses. After upgrading to go 1.21.5, it was giving an error in the static analysis regarding imports. Signed-off-by: Ivan Valdes <[email protected]>
ivanvc
force-pushed
the
update-go-to-1.21.5
branch
from
5ef1513
to
fbbe39f
Compare
ahrtr
approved these changes
Dec 6, 2023
jmhbnz
approved these changes
Dec 6, 2023
serathius
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates go version to 1.21.5 as tracked in etcd-io/etcd#17049.