Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: single source of truth for DerivationVersion #11901

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

refactor: single source of truth for DerivationVersion #11901

wants to merge 1 commit into from
+26 −23

Conversation

zhiqiangxu
Copy link
Contributor

@zhiqiangxu zhiqiangxu commented Sep 13, 2024 •
edited
Loading

Currently the DerivationVersion1 is not used, and TxDataVersion1 is used instead, both refer to the same thing.

This PR makes versions.go the single source of truth for DerivationVersion.

@zhiqiangxu zhiqiangxu requested review from a team as code owners September 13, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protolambda protolambda Awaiting requested review from protolambda protolambda is a code owner automatically assigned from ethereum-optimism/consensus

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zhiqiangxu