Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

feat(Makefile): use Makefile for running tasks, retiring gulp #2651

Closed
wants to merge 4 commits into from

Conversation

debloper
Copy link
Contributor

@debloper debloper commented May 21, 2018

What does this PR do?

This sets up the base to replace Gulp as a task runner, with Make. For the moment, both will work so that developers can get accustomed with the new set of commands. Once the transition phase is over, Gulp can be safely removed from repo and Make can take its place as user-run commands as well as in CI/CD routines.

What issue/task does this PR references?

#2506 & https://openshift.io/openshiftio/openshiftio/plan/detail/2419

Are the tests Included?

Not Applicable

@centos-ci
Copy link
Collaborator

@debloper Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2651 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2651 and visit http://localhost:5000 to access it.

@sanbornsen
Copy link
Contributor

Can you write a readme for this? How do we build the planner with this setup?

@debloper
Copy link
Contributor Author

debloper commented May 22, 2018

@sanbornsen don't you worry sire, coming right up. 🤓

I want to keep the Makefile side-by-side with Gulp for a few weeks though (for everyone to catch up in their free time, and not end up being forced to learn new thing when they would rather work on something else). Both will generate same results, and not be blocking each other - so, during this transition phase, you're free to use either/both.

During this phase, I'll follow up another patch that replaces Gulp in the CI/CD and also incorporates all the ad-hoc scripts we have lying around in the repo as Makefile targets which are too complicated for a gulp-task (e.g. make dev to immediately setup, build, and watch for developers to start working on it - as a replacement for run-planner.sh, as well as the cico-scripts).

@centos-ci
Copy link
Collaborator

@debloper Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2651 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2651 and visit http://localhost:5000 to access it.

Copy link
Collaborator

@nimishamukherjee nimishamukherjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention the experience or scenario that this PR addresses.

@debloper debloper changed the title [WIP] feat(Makefile): use Makefile for running tasks, retiring gulp feat(Makefile): use Makefile for running tasks, retiring gulp May 25, 2018
@debloper debloper force-pushed the makefile branch 3 times, most recently from 5ee600b to 8c37bee Compare May 28, 2018 12:48
@centos-ci
Copy link
Collaborator

@debloper Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2651 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2651 and visit http://localhost:5000 to access it.

@centos-ci
Copy link
Collaborator

@debloper Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2651 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2651 and visit http://localhost:5000 to access it.

1 similar comment
@centos-ci
Copy link
Collaborator

@debloper Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2651 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2651 and visit http://localhost:5000 to access it.

@debloper
Copy link
Contributor Author

Took @jarifibrahim through the code and implementation, along with comparing it against the Gulpfile.
I believe he should be able to maintain this (if it's considered as a value addition) in my absence.

@joshuawilson
Copy link
Contributor

Since we are moving to a monorepo and this is really out of date, I'm closing it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants