Skip to content

Commit

Permalink
Fix integration test (#2282)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #2282

X-link: facebookresearch/aepsych#338

Previously the integration test was failing due to not allowing unlimited trials on the last step. This is because the final step was copied from the exisiting botorch step (which contains transition criterion). If transition criterion exist on the step/node, we default to using those for determining the state of the node.

This fixes the test by manually unsetting the transition criterion arg for the aepsych strategy.py.

We also re-enable the test

Reviewed By: crasanders

Differential Revision: D54960088

fbshipit-source-id: e9c61f5ddefe45f5a9824c6dbd9068989a03bf72
  • Loading branch information
mgarrard authored and facebook-github-bot committed Mar 18, 2024
1 parent 5e4d18d commit 23636ed
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ax/modelbridge/generation_strategy.py
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ def _validate_and_set_step_sequence(self, steps: List[GenerationStep]) -> None:

# Set transition_to field for all but the last step, which remains
# null.
if idx != len(self._steps):
if idx != len(self._steps) - 1:
for transition_criteria in step.transition_criteria:
if (
transition_criteria.criterion_class
Expand Down

0 comments on commit 23636ed

Please sign in to comment.