Skip to content

Commit

Permalink
load aux experiments with skip_runners_and_metrics=True (#2768)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #2768

Load aux experiments with `skip_runners_and_metrics=True` by default.

meta: when an exp is saved with application specific (e.g., PTS) encoder, trying to load its metrics with a generic FBDecoder (and OSS one probably as well) will result in fail to load metric error.

Reviewed By: Balandat

Differential Revision: D62661185
  • Loading branch information
ItsMrLin authored and facebook-github-bot committed Sep 16, 2024
1 parent 8f88a89 commit ff63b38
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion ax/storage/sqa_store/decoder.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,11 @@ def _auxiliary_experiments_by_purpose_from_experiment_sqa(
for aux_exp_name in aux_exp_names:
auxiliary_experiments_by_purpose[aux_exp_purpose].append(
AuxiliaryExperiment(
experiment=load_experiment(aux_exp_name, config=self.config)
experiment=load_experiment(
aux_exp_name,
config=self.config,
skip_runners_and_metrics=True,
)
)
)
return auxiliary_experiments_by_purpose
Expand Down
2 changes: 1 addition & 1 deletion ax/storage/sqa_store/load.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def load_experiment(
config: `SQAConfig`, from which to retrieve the decoder. Optional,
defaults to base `SQAConfig`.
reduced_state: Whether to load experiment with a slightly reduced state
(without abandoned arms on experiment and withoug model state,
(without abandoned arms on experiment and without model state,
search space, and optimization config on generator runs).
skip_runners_and_metrics: If True skip loading runners, and do only a
minimal load of metrics. This option is intended to enable loading of
Expand Down

0 comments on commit ff63b38

Please sign in to comment.