Submitit integration #2125
Draft
Submitit integration #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
mhavasi
commented
Jan 9, 2024
There was a problem hiding this comment.
The code in submitit.py is a 90% copy-paste of Michael Shvartsman's code here (https://github.com/mshvartsman/Ax/blob/submitit-runner/ax/runners/submitit.py).
|
|
||
| elif isinstance(self.executor, LocalExecutor): | ||
| ############ | ||
| ##### this fails to pickle, doesn't work |
| from submitit.core.core import Executor | ||
|
|
||
|
|
||
| class SubmitItRunner(Runner): |
There was a problem hiding this comment.
Are poll_exception and poll_available_capacity important to define for a Runner?
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2125 +/- ##
==========================================
- Coverage 94.79% 94.68% -0.12%
==========================================
Files 460 461 +1
Lines 45400 45457 +57
==========================================
+ Hits 43039 43040 +1
- Misses 2361 2417 +56 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds a runner for the SubmitIt package (https://github.com/facebookincubator/submitit). With the SubmitIt package, we can use the Ax scheduler to schedule jobs on a SLURM cluster.
The integration requires defining a Runner and a Metric for SubmitIt executors (submitit.py). The quick-start guide (submitit_scheduler.py) explains how to set-up a basic experiment and directs the user towards further Ax resources that they may be interested in.