Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimplifyParameterConstraints #2326

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

dme65
Copy link
Contributor

@dme65 dme65 commented Apr 5, 2024

Summary: Remove parameter constraints that can be trivially converted into an updated lower/upper bound

Reviewed By: SebastianAment

Differential Revision: D55718753

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 5, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55718753

dme65 pushed a commit to dme65/Ax that referenced this pull request Apr 5, 2024
Summary:

Remove parameter constraints that can be trivially converted into an updated lower/upper bound

Reviewed By: SebastianAment

Differential Revision: D55718753
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55718753

Summary:

Remove parameter constraints that can be trivially converted into an updated lower/upper bound

Reviewed By: SebastianAment

Differential Revision: D55718753
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55718753

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.15385% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 94.90%. Comparing base (05eb25f) to head (e7aa915).

❗ Current head e7aa915 differs from pull request most recent head 6cab8e3. Consider uploading reports for the commit 6cab8e3 to get more accurate results

Files Patch % Lines
...ridge/transforms/simplify_parameter_constraints.py 91.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2326      +/-   ##
==========================================
- Coverage   94.90%   94.90%   -0.01%     
==========================================
  Files         489      491       +2     
  Lines       47756    47834      +78     
==========================================
+ Hits        45324    45398      +74     
- Misses       2432     2436       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SebastianAment pushed a commit to SebastianAment/Ax that referenced this pull request Apr 5, 2024
Summary:
Pull Request resolved: facebook#2326

Remove parameter constraints that can be trivially converted into an updated lower/upper bound

Differential Revision: D55718753

Reviewed By: SebastianAment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants