Pull out mixin for setting X_pending
in acquisition functions
#2332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Formerly, all subclasses of
Acquisition
had a methodset_X_pending
, even if they did not support pending points. This confused me while writing tests for optimizing acquisition functions.XPendingMixin
so that classes only have the methodset_X_pending
where it is functional and appropriateset_X_pending
methodoptimize_acqf
and similar functions; added more precise type hints.Differential Revision: D55843962