Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order contours by abs(sensitivity) rather than raw sensitivity #2702

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ax/service/utils/report_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ def _get_objective_v_param_plots(
# sort the params by their sensitivity
params_to_use = sorted(
range_params_sens_for_metric,
key=lambda x: range_params_sens_for_metric[x],
key=lambda x: abs(range_params_sens_for_metric[x]),
reverse=True,
)[:num_params_per_metric]
# if sens is not available, just use the first num_features_per_metric.
Expand Down Expand Up @@ -1187,6 +1187,9 @@ def _update_fig_in_place(scheduler: "Scheduler") -> None:
overwrite=True,
)

# pyre-fixme[7]: Expected `Tuple[Figure, typing.Callable[[Scheduler], None]]` but
# got `Tuple[FigureWidget, typing.Callable($local_ax?service?utils?report_utils?get_
# figure_and_callback$_update_fig_in_place)[[Named(scheduler, Scheduler)], None]]`.
return fig, _update_fig_in_place


Expand Down
Loading