Update comment on validate sphinx to be more helpful #2751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62313321 |
Summary: Pull Request resolved: facebook#2751 This was failing for me and it wasn't immediately clear what file to update and where that file would be located. Hopefully just makes it easier for anyone who hits this failure in the future. If we hate this idc if we don't want to commit it Differential Revision: D62313321
|
This pull request was exported from Phabricator. Differential Revision: D62313321 |
mgarrard
force-pushed
the
export-D62313321
branch
from
e174574
to
a3ac747
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2751 +/- ##
=======================================
Coverage 95.47% 95.47%
=======================================
Files 489 489
Lines 47876 47876
=======================================
Hits 45709 45709
Misses 2167 2167 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in a8d4420. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This was failing for me and it wasn't immediately clear what file to update and where that file would be located. Hopefully just makes it easier for anyone who hits this failure in the future.
If we hate this idc if we don't want to commit it
Differential Revision: D62313321