-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add remaining n input constructor #2758
base: main
Are you sure you want to change the base?
Conversation
…t at 9/6/2024, 10:19:43 AM Differential Revision: D62247100
Summary: todo Differential Revision: D62310414
Summary: todo Differential Revision: D62252945
This pull request was exported from Phabricator. Differential Revision: D62467907 |
Summary: Pull Request resolved: facebook#2758 This diff adds the input constructor for our default logic for repeat arms. See note in comments about how this new logic differs Follow up diffs: - update the transition logic to leverage this - storage --> let's do this once we all like the 3 input constructors - update the input constructors to handle the case where n isn't provided as a kwarg - add tests for real world scenario per Liz suggestion - add test to enforce signature across input constructors per Liz/Sait/Daniel suggestion Differential Revision: D62467907
This pull request was exported from Phabricator. Differential Revision: D62467907 |
cd76008
to
1d685ac
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2758 +/- ##
=======================================
Coverage 95.60% 95.60%
=======================================
Files 489 491 +2
Lines 47903 47988 +85
=======================================
+ Hits 45796 45880 +84
- Misses 2107 2108 +1 ☔ View full report in Codecov by Sentry. |
Summary:
This diff adds the input constructor for our default logic for repeat arms. See note in comments about how this new logic differs
Follow up diffs:
Differential Revision: D62467907