Use input constructors during GS #2761
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 11, 2024 20:28
…t at 9/6/2024, 10:19:43 AM Differential Revision: D62247100
Summary: todo Differential Revision: D62310414
Summary: todo Differential Revision: D62252945
Differential Revision: D62467907
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62316641 |
Summary: Pull Request resolved: facebook#2761 This diff adds support for leveraging the input constructors during gs.gen_with_multiple_nodes(..), as part of this we also add _previous_node param on gennodes. We presist the arms_per_node argument as we believe this is likely useful for researchers and developers internally, but this should never be exposed at api level to not cause confusion. we also add a e2e style unit test Follow up diffs: - storage --> let's do this once we all like the 3 input constructors - update the input constructors to handle the case where n isn't provided as a kwarg - add tests for real world scenario per Liz suggestion - add test to enforce signature across input constructors per Liz/Sait/Daniel suggestion Differential Revision: D62316641
|
This pull request was exported from Phabricator. Differential Revision: D62316641 |
mgarrard
force-pushed
the
export-D62316641
branch
from
1135f6f
to
763dac2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds support for leveraging the input constructors during gs.gen_with_multiple_nodes(..), as part of this we also add _previous_node param on gennodes. We presist the arms_per_node argument as we believe this is likely useful for researchers and developers internally, but this should never be exposed at api level to not cause confusion.
we also add a e2e style unit test
Follow up diffs:
Differential Revision: D62316641