Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(iOS): refactor RCTImageUtils, RCTTextView & RCTParagraphComponentView.mm to use UTType #46532

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(iOS): refactor RCTImageUtils, RCTTextView & RCTParagraphComponentView.mm to use UTType #46532

wants to merge 2 commits into from
+13 −8

Conversation

krozniata
Copy link
Contributor

Summary:

This PR refactors RCTImageUtils, RCTTextView & RCTParagraphComponentView.mm to use UTType because of deprecation warning from iOS 15 and above

Changelog:

[IOS] [CHANGED] - Refactor RCTImageUtils, RCTTextView & RCTParagraphComponentView.mm to use UTType

Test Plan:

Make sure that RNTester builds and runs correctly

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 17, 2024
cipolleschi
cipolleschi approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this cleanup. I'll import it and 🤞 that the internal pipeline would like it!

@cipolleschi
Copy link
Contributor

Actually, CI is failing with

ld: Undefined symbols:
 _UTTypeFlatRTFD, referenced from:
  -[RCTTextView copy:] in RCTTextView.o
   _UTTypeUTF8PlainText, referenced from:
      -[RCTTextView copy:] in RCTTextView.o
clang: error: linker command failed with exit code 1 (use -v to see invocation)
 Ld /Users/runner/Library/Developer/Xcode/DerivedData/HelloWorld-czqnsntrjgyngsfxcbfgwyssconw/Build/Intermediates.noindex/Pods.build/Release-iphonesimulator/React-RCTText.build/Objects-normal/arm64/Binary/RCTText normal arm64 (in target 'React-RCTText' from project 'Pods')

It's likely that we have to add a framework to the React-RCTText.podspec file.
Could you look into it?

@krozniata
Copy link
Contributor Author

Sure!

@krozniata
Copy link
Contributor Author

@cipolleschi I've added missing framework, looks like everything builds correctly 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipolleschi cipolleschi cipolleschi approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krozniata @cipolleschi @facebook-github-bot