Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

menu: fix CFBundleName and multiple about windows #17

Merged
merged 2 commits into from
Jan 12, 2024
Merged

menu: fix CFBundleName and multiple about windows #17

merged 2 commits into from
Jan 12, 2024

Conversation

eagleoflqj
Copy link
Member

Shouldn't show CFBundleName on Chinese locale.
Use a singleton NSWindowController so no multiple window instances as well.

@eagleoflqj eagleoflqj requested a review from ksqsf January 12, 2024 04:29
Copy link
Member

@ksqsf ksqsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

LGTM

@ksqsf ksqsf merged commit 51c8bc3 into master Jan 12, 2024
4 checks passed
@ksqsf ksqsf deleted the menu branch January 12, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants