fix: Added Online Store REST client errors handler #4488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Theodor Mihalache <[email protected]>
tmihalac
changed the title
| utils.make_tzaware(parser.parse(request.end_ts)), request.feature_views | ||
| ) | ||
|
|
||
| @app.exception_handler(Exception) |
There was a problem hiding this comment.
Very nice, I didn't realize FastAPI had a global exception handler.
https://fastapi.tiangolo.com/tutorial/handling-errors/#install-custom-exception-handlers
dmartinol
reviewed
Sep 5, 2024
dmartinol
reviewed
Sep 5, 2024
- Small refactor to from_error_detail and FeastErrors - Fixed tests Signed-off-by: Theodor Mihalache <[email protected]>
- Fixed linter Signed-off-by: Theodor Mihalache <[email protected]>
dmartinol
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added a decorator for rest calls to remote online server failures and adds an additional message to the response with the failure status and details.
The proxy client then rebuilds the original error from the status data.
Which issue(s) this PR fixes:
Fixes #4481