Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Import grpc only for type checking in errors.py #4533

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

fix: Import grpc only for type checking in errors.py #4533

wants to merge 13 commits into from

Conversation

tokoko
Copy link
Collaborator

@tokoko tokoko commented Sep 18, 2024 •
edited
Loading

Fixes #4532
Also fixes #4344

@dmartinol
Copy link
Contributor

should we also mention the new make targets in the dev guide document?

@tokoko
Copy link
Collaborator Author

tokoko commented Sep 18, 2024

@franciscojavierarceo Also added a test for import feast with no optional dependencies as part of this PR addressing #4344.

franciscojavierarceo
franciscojavierarceo reviewed Sep 18, 2024
View reviewed changes
.github/workflows/smoke_tests.yml
@@ -0,0 +1,38 @@
name: smoke-tests
Copy link
Member

@franciscojavierarceo franciscojavierarceo Sep 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscojavierarceo franciscojavierarceo franciscojavierarceo left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
3 participants
@tokoko @dmartinol @franciscojavierarceo