Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adding protobuf<5 as a required dependency due to snowflake limitations #4537

Merged
merged 4 commits into from
Sep 19, 2024
Merged

fix: Adding protobuf<5 as a required dependency due to snowflake limitations #4537

merged 4 commits into from
Sep 19, 2024

Conversation

EXPEbdodla
Copy link
Contributor

What this PR does / why we need it:

  1. I have issues running lock python dependencies locally. The is the amendment to PR fix: Removed protobuf as a required dependency #4535. Resolved the issue by deleting the requirements files and ran the lock target again which generated the correct files.

Which issue(s) this PR fixes:

Misc

@EXPEbdodla EXPEbdodla changed the title fix: Ran lock python dependencies to correct dependencies fix: Adding protobuf<5 as a required dependency due to snowflake limitations Sep 19, 2024
@EXPEbdodla EXPEbdodla changed the title fix: Adding protobuf<5 as a required dependency due to snowflake limitations fix: Adding protobuf<5 as a required dependency due to snowflake limitations Sep 19, 2024
@tokoko tokoko merged commit cecca83 into feast-dev:master Sep 19, 2024
16 of 17 checks passed
@EXPEbdodla EXPEbdodla deleted the fix_protobuf_dependency_conflict branch September 19, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokoko tokoko tokoko approved these changes

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EXPEbdodla @tokoko