Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Added indexes to sql tables to optimize query execution #4538

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

EXPEbdodla
Copy link
Contributor

What this PR does / why we need it:

  1. Indexes help to optimize the query execution when the tables are growing. Based my local test, I see an improvement of 40-60% in query execution time.

Which issue(s) this PR fixes:

Misc

@EXPEbdodla EXPEbdodla changed the title minor: Added indexes to sql tables to optimize query execution perf: Added indexes to sql tables to optimize query execution Sep 19, 2024
Copy link
Collaborator

@tokoko tokoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I'll merge as soon as I manage to make the tests pass

@EXPEbdodla
Copy link
Contributor Author

Did an empty commit to trigger the GitHub Actions.

@tokoko tokoko merged commit 9688790 into feast-dev:master Sep 19, 2024
15 checks passed
@EXPEbdodla EXPEbdodla deleted the add_sql_indexes branch September 19, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants