chore: Commit generated python proto files #4546
Open
+9,568
−665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tokoko <[email protected]>
Signed-off-by: tokoko <[email protected]>
tokoko
force-pushed
the
commit-proto-files
branch
from
522f4c6
to
04b92c1
Compare
Signed-off-by: tokoko <[email protected]>
|
Support ends for 4.25.* by end of 2025 Q1. https://protobuf.dev/support/version-support/#python Conda now has 5.* version packages. https://github.com/conda-forge/protobuf-feedstock/pulls?q=is%3Apr+is%3Aclosed https://anaconda.org/conda-forge/protobuf/files Can we try with Version 5 now and see what happens now? We may need lock Protobuf dependency to a version which conda supports. We can do that in a next PR. So we get benefits of Protobuf v5. |
|
@EXPEbdodla That's a perfect timing 😆 I'd still prefer to defer it to another PR, because we might have that runtime version warning problem to solve somehow with protobuf 5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes #4541