Add support for ruff #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrostyX
force-pushed
the
ruff
branch
2 times, most recently
from
f1926fc
to
2384dfa
Compare
xsuchy
reviewed
Aug 24, 2024
| """ | ||
| Run `ruff check` and return a dict with its results | ||
| """ | ||
| cmd = ["ruff", "check", "--output-format=json"] + sys.argv[1:] |
There was a problem hiding this comment.
Should it be added as a weak deps to spec file?
Should the argv be sanitized?
There was a problem hiding this comment.
Should it be added as a weak deps to spec file?
It should, thank you. Good catch.
Should the argv be sanitized?
I don't know, I did the same that vcs-diff-lint-csdiff-pylint does. But probably not? Worst case scenario, the bad values are going to be passed to ruff check which will handle it and error out.
There was a problem hiding this comment.
Right, with the shell=False (that is the default) this is not a problem.
praiskup
approved these changes
Aug 26, 2024
|
Thank you! |
FrostyX
added a commit
to FrostyX/vcs-diff-lint-action
that referenced
this pull request
Aug 27, 2024
FrostyX
added a commit
to FrostyX/vcs-diff-lint-action
that referenced
this pull request
Aug 28, 2024
FrostyX
added a commit
to fedora-copr/vcs-diff-lint-action
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #17
See https://docs.astral.sh/ruff