Skip to content

Commit

Permalink
pylint anitya/tests/lib/backends
Browse files Browse the repository at this point in the history
  • Loading branch information
lmilbaum authored and mergify[bot] committed Jun 22, 2023
1 parent 6f58745 commit 0e52938
Show file tree
Hide file tree
Showing 25 changed files with 43 additions and 31 deletions.
2 changes: 1 addition & 1 deletion anitya/tests/lib/backends/test_bitbucket.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class BitBucketBackendtests(DatabaseTestCase):

def setUp(self):
"""Set up the environnment, ran before every tests."""
super(BitBucketBackendtests, self).setUp()
super().setUp()

create_distro(self.session)
self.create_project()
Expand Down
2 changes: 1 addition & 1 deletion anitya/tests/lib/backends/test_cgit.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class CgitBackendtests(DatabaseTestCase):

def setUp(self):
"""Set up the environment, ran before every tests."""
super(CgitBackendtests, self).setUp()
super().setUp()

create_distro(self.session)
self.create_project()
Expand Down
2 changes: 1 addition & 1 deletion anitya/tests/lib/backends/test_cpan.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class CpanBackendtests(DatabaseTestCase):

def setUp(self):
"""Set up the environnment, ran before every tests."""
super(CpanBackendtests, self).setUp()
super().setUp()

create_distro(self.session)
self.create_project()
Expand Down
4 changes: 2 additions & 2 deletions anitya/tests/lib/backends/test_crates.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class CratesBackendTests(DatabaseTestCase):

def setUp(self):
"""Set up the environnment, run before every test"""
super(CratesBackendTests, self).setUp()
super().setUp()
self.create_project()

def create_project(self):
Expand Down Expand Up @@ -97,7 +97,7 @@ def test__get_versions_no_json(self, mock_call_url):
mock_call_url.return_value.json.side_effect = ValueError
project = models.Project.by_id(self.session, 1)
with self.assertRaises(AnityaPluginException) as context_manager:
crates.CratesBackend._get_versions(project)
crates.CratesBackend._get_versions(project) # pylint: disable=W0212
self.assertIn("Failed to decode JSON", str(context_manager.exception))

def test_get_versions_not_modified(self):
Expand Down
2 changes: 1 addition & 1 deletion anitya/tests/lib/backends/test_custom.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class CustomBackendtests(DatabaseTestCase):

def setUp(self):
"""Set up the environnment, ran before every tests."""
super(CustomBackendtests, self).setUp()
super().setUp()

create_distro(self.session)
self.create_project()
Expand Down
2 changes: 1 addition & 1 deletion anitya/tests/lib/backends/test_debian.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class DebianBackendtests(DatabaseTestCase):

def setUp(self):
"""Set up the environnment, ran before every tests."""
super(DebianBackendtests, self).setUp()
super().setUp()

create_distro(self.session)
self.create_project()
Expand Down
2 changes: 1 addition & 1 deletion anitya/tests/lib/backends/test_drupal6.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class Drupal6Backendtests(DatabaseTestCase):

def setUp(self):
"""Set up the environnment, ran before every tests."""
super(Drupal6Backendtests, self).setUp()
super().setUp()

create_distro(self.session)
self.create_project()
Expand Down
2 changes: 1 addition & 1 deletion anitya/tests/lib/backends/test_freshmeat.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class FreshmeatBackendtests(DatabaseTestCase):

def setUp(self):
"""Set up the environnment, ran before every tests."""
super(FreshmeatBackendtests, self).setUp()
super().setUp()

create_distro(self.session)
self.create_project()
Expand Down
5 changes: 3 additions & 2 deletions anitya/tests/lib/backends/test_github.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class GithubBackendtests(DatabaseTestCase):

def setUp(self):
"""Set up the environnment, ran before every tests."""
super(GithubBackendtests, self).setUp()
super().setUp()

create_distro(self.session)
self.create_projects()
Expand Down Expand Up @@ -285,6 +285,7 @@ def test_get_version_url_project_version_url_contains_tags(self):
self.assertEqual(obs, exp)

def test_get_version_url_project_version_url_contains_releases(self):
"""test_get_version_url_project_version_url_contains_releases"""
project = models.Project(
name="Releases Repository",
version_url="fedora-infra/releases",
Expand Down Expand Up @@ -512,7 +513,7 @@ class JsonTests(unittest.TestCase):
"""

def __init__(self, *args, **kwargs):
super(JsonTests, self).__init__(*args, **kwargs)
super().__init__(*args, **kwargs)
self.maxDiff = None
self.project = models.Project(
name="foobar",
Expand Down
2 changes: 1 addition & 1 deletion anitya/tests/lib/backends/test_gitlab.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class GitlabBackendtests(DatabaseTestCase):

def setUp(self):
"""Set up the environnment, ran before every tests."""
super(GitlabBackendtests, self).setUp()
super().setUp()

create_distro(self.session)
self.create_project()
Expand Down
2 changes: 1 addition & 1 deletion anitya/tests/lib/backends/test_gnu.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class GnuBackendtests(DatabaseTestCase):

def setUp(self):
"""Set up the environnment, ran before every tests."""
super(GnuBackendtests, self).setUp()
super().setUp()

create_distro(self.session)
self.create_project()
Expand Down
2 changes: 1 addition & 1 deletion anitya/tests/lib/backends/test_gogs.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class GogsBackendtests(DatabaseTestCase):

def setUp(self):
"""Set up the environment, ran before every tests."""
super(GogsBackendtests, self).setUp()
super().setUp()

create_distro(self.session)
self.create_project()
Expand Down
2 changes: 1 addition & 1 deletion anitya/tests/lib/backends/test_hackage.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class HackageBackendtests(DatabaseTestCase):

def setUp(self):
"""Set up the environnment, ran before every tests."""
super(HackageBackendtests, self).setUp()
super().setUp()

create_distro(self.session)
self.create_project()
Expand Down
11 changes: 6 additions & 5 deletions anitya/tests/lib/backends/test_init.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@


class BaseBackendTests(AnityaTestCase):
"""BaseBackendTests"""

def setUp(self):
super(BaseBackendTests, self).setUp()
super().setUp()
self.backend = backends.BaseBackend()
self.headers = {
"User-Agent": "Anitya {0} at release-monitoring.org".format(
anitya.app.__version__
),
"User-Agent": f"Anitya {anitya.app.__version__} at release-monitoring.org",
"From": config.get("ADMIN_EMAIL"),
"If-modified-since": "Thu, 01 Jan 1970 00:00:00 GMT",
}
Expand Down Expand Up @@ -82,7 +82,7 @@ def test_call_ftp_url(self, mock_urllib):

mock_urllib.assert_called_once_with(mock.ANY)

args, kwargs = mock_urllib.call_args
args, _ = mock_urllib.call_args
req = args[0]

self.assertEqual(req_exp.get_full_url(), req.get_full_url())
Expand Down Expand Up @@ -138,6 +138,7 @@ def test_expand_subdirs_ftp(self, mock_call_url):

@mock.patch("anitya.lib.backends.http_session")
def test_call_url_last_change(self, mock_http_session):
"""Test call url last change"""
url = "https://www.example.com/"
exp_headers = self.headers.copy()
time = arrow.utcnow()
Expand Down
2 changes: 1 addition & 1 deletion anitya/tests/lib/backends/test_launchpad.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class LaunchpadBackendtests(DatabaseTestCase):

def setUp(self):
"""Set up the environnment, ran before every tests."""
super(LaunchpadBackendtests, self).setUp()
super().setUp()

create_distro(self.session)
self.create_project()
Expand Down
11 changes: 10 additions & 1 deletion anitya/tests/lib/backends/test_maven.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,51 +38,59 @@ class MavenBackendTest(DatabaseTestCase):

def setUp(self):
"""Set up the environnment, ran before every tests."""
super(MavenBackendTest, self).setUp()
super().setUp()

create_distro(self.session)

def assert_plexus_version(self, **kwargs):
"""assert_plexus_version"""
project = models.Project(backend=BACKEND, **kwargs)
exp = "1.3.8"
obs = MavenBackend.get_version(project)
self.assertEqual(obs, exp)

def assert_invalid(self, **kwargs):
"""assert_invalid"""
project = models.Project(backend=BACKEND, **kwargs)
self.assertRaises(AnityaPluginException, MavenBackend.get_version, project)

def test_maven_nonexistent(self):
"""test_maven_nonexistent"""
self.assert_invalid(name="foo", homepage="https://example.com")

def test_maven_coordinates_in_version_url(self):
"""test_maven_coordinates_in_version_url"""
self.assert_plexus_version(
name="plexus-maven-plugin",
version_url="org.codehaus.plexus:plexus-maven-plugin",
homepage="https://plexus.codehaus.org/",
)

def test_maven_coordinates_in_name(self):
"""test_maven_coordinates_in_name"""
self.assert_plexus_version(
name="org.codehaus.plexus:plexus-maven-plugin",
homepage="https://plexus.codehaus.org/",
)

def test_maven_bad_coordinates(self):
"""test_maven_bad_coordinates"""
self.assert_invalid(
name="plexus-maven-plugin",
homepage="https://plexus.codehaus.org/",
version_url="plexus-maven-plugin",
)

def test_maven_get_version_by_url(self):
"""test_maven_get_version_by_url"""
self.assert_plexus_version(
name="plexus-maven-plugin",
homepage="https://repo1.maven.org/maven2/"
"org/codehaus/plexus/plexus-maven-plugin/",
)

def test_dots_in_artifact_id(self):
"""test_dots_in_artifact_id"""
project = models.Project(
backend=BACKEND,
name="felix-gogo-shell",
Expand Down Expand Up @@ -156,6 +164,7 @@ def test_get_version_url_wrong_homepage(self):
self.assertEqual(obs, exp)

def test_maven_get_versions(self):
"""test_maven_get_versions"""
project = models.Project(
backend=BACKEND,
name="plexus-maven-plugin",
Expand Down
2 changes: 1 addition & 1 deletion anitya/tests/lib/backends/test_npmjs.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class NpmjsBackendtests(DatabaseTestCase):

def setUp(self):
"""Set up the environnment, ran before every tests."""
super(NpmjsBackendtests, self).setUp()
super().setUp()

create_distro(self.session)
self.create_project()
Expand Down
2 changes: 1 addition & 1 deletion anitya/tests/lib/backends/test_packagist.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class PackagistBackendtests(DatabaseTestCase):

def setUp(self):
"""Set up the environnment, ran before every tests."""
super(PackagistBackendtests, self).setUp()
super().setUp()

create_distro(self.session)
self.create_project()
Expand Down
2 changes: 1 addition & 1 deletion anitya/tests/lib/backends/test_pecl.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class PeclBackendtests(DatabaseTestCase):

def setUp(self):
"""Set up the environnment, ran before every tests."""
super(PeclBackendtests, self).setUp()
super().setUp()

create_distro(self.session)
self.create_project()
Expand Down
2 changes: 1 addition & 1 deletion anitya/tests/lib/backends/test_pypi.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class PypiBackendtests(DatabaseTestCase):

def setUp(self):
"""Set up the environnment, ran before every tests."""
super(PypiBackendtests, self).setUp()
super().setUp()

create_distro(self.session)

Expand Down
2 changes: 1 addition & 1 deletion anitya/tests/lib/backends/test_rubygems.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class RubygemsBackendtests(DatabaseTestCase):

def setUp(self):
"""Set up the environnment, ran before every tests."""
super(RubygemsBackendtests, self).setUp()
super().setUp()

create_distro(self.session)
self.create_project()
Expand Down
2 changes: 1 addition & 1 deletion anitya/tests/lib/backends/test_sourceforge.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class SourceforgeBackendtests(DatabaseTestCase):

def setUp(self):
"""Set up the environnment, ran before every tests."""
super(SourceforgeBackendtests, self).setUp()
super().setUp()

create_distro(self.session)
self.create_project()
Expand Down
3 changes: 2 additions & 1 deletion anitya/tests/lib/backends/test_sourceforge_git.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class SourceforgeGitBackendtests(DatabaseTestCase):

def setUp(self):
"""Set up the environnment, ran before every tests."""
super(SourceforgeGitBackendtests, self).setUp()
super().setUp()

create_distro(self.session)
self.create_project()
Expand Down Expand Up @@ -250,6 +250,7 @@ def test_get_versions(self):
self.assertEqual(sorted(obs), exp)

def test_get_versions_url_not_valid(self):
"""Test get versions url not valid"""
pid = 2
project = models.Project.get(self.session, pid)
self.assertRaises(
Expand Down
2 changes: 1 addition & 1 deletion anitya/tests/lib/backends/test_sourcehut.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class SourceHutBackendTests(DatabaseTestCase):

def setUp(self):
"""Set up the environment, ran before every tests."""
super(SourceHutBackendTests, self).setUp()
super().setUp()

create_distro(self.session)
self.create_project()
Expand Down
2 changes: 1 addition & 1 deletion anitya/tests/lib/backends/test_stackage.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class HackageBackendtests(DatabaseTestCase):

def setUp(self):
"""Set up the environnment, ran before every tests."""
super(HackageBackendtests, self).setUp()
super().setUp()

create_distro(self.session)
self.create_project()
Expand Down

0 comments on commit 0e52938

Please sign in to comment.